Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication]: Cleaned up ACS samples #18656

Merged
merged 2 commits into from
May 12, 2021

Conversation

lsundaralingam
Copy link
Member

No description provided.

@ghost ghost added the Communication label May 12, 2021
@lsundaralingam
Copy link
Member Author

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam marked this pull request as ready for review May 12, 2021 18:13
Copy link
Member

@beltr0n beltr0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're in clean up, I don't think ACS account is the right term. It's part of the ACS resource in your Azure account. maybe change it to ACS resource?

@lsundaralingam
Copy link
Member Author

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam merged commit 802c887 into Azure:master May 12, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request May 25, 2022
[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 (Azure#18656)

* Add comment to Change state parameters

* fix error

* fix error

* fix

* fix

* fix error

* fix validations

* add example for operation list command

* fix example

* fix example

* fix

* fix

* delete json file

* add origin parameter to operation defenition

* fix

* fix

* fix

* delete unneccesary files

* revert packege-lock.json file changes

Co-authored-by: Khaled Abo Asbe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants